Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycled chain breaks sequence canvas and entire app #4824

Closed
AlexeyGirin opened this issue Jun 10, 2024 · 1 comment · Fixed by #4826 or #4829
Closed

Cycled chain breaks sequence canvas and entire app #4824

AlexeyGirin opened this issue Jun 10, 2024 · 1 comment · Fixed by #4826 or #4829
Assignees
@rrodionov91
Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.22.0-rc.4

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 10, 2024 •
edited
Loading

Steps to Reproduce

  1. Load from file: Simple cycle.zip
    OR put on the canvas following configuration:
    image
  2. Switch to Sequence mode

Actual behavior

  1. Sequence canvas is empty
    image
  2. Library is enabled (you can take any monomer and put it on the sequence canvas!)
    image

Expected behavior
Cycled sequence shown on the screen
image
Library is disabled

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.3 Build at 2024-06-10; 12:34:49
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues labels Jun 10, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.4 milestone Jun 10, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 10, 2024
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4824 - Cycled chain breaks sequence canvas and entire app
025dce8 
- fixed case with infinite loop in chains analysis if phosphate is first in cycled chain
@rrodionov91 rrodionov91 linked a pull request Jun 10, 2024 that will close this issue
#4824 - Cycled chain breaks sequence canvas and entire app #4826
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4824 - Cycled chain breaks sequence canvas and entire app (#4826)
5e11648 
- fixed case with infinite loop in chains analysis if phosphate is first in cycled chain
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4824 - Cycled chain breaks sequence canvas and entire app
f509957 
- fixed case with infinite loop in chains analysis if phosphate is first in cycled chain
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
Revert "#4824 - Cycled chain breaks sequence canvas and entire app"
2109b3c 
This reverts commit f509957.
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4824 - Cycled chain breaks sequence canvas and entire app
26bb892 
- fixed case with infinite loop in chains analysis if phosphate is first in cycled chain

(cherry picked from commit f509957)
@rrodionov91 rrodionov91 linked a pull request Jun 10, 2024 that will close this issue
Backmerge: #4824 - Cycled chain breaks sequence canvas and entire app #4829
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.4 Build at 2024-06-10; 17:29:31
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

rrodionov91 added a commit that referenced this issue Jun 17, 2024
@rrodionov91
Backmerge: #4824 - Cycled chain breaks sequence canvas and entire app (…
c11c8ad 
…#4829)

- fixed case with infinite loop in chains analysis if phosphate is first in cycled chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.22.0-rc.4
2 participants
@rrodionov91 @AlexeyGirin