Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In sequence mode, each press adds two characters and when deleted, also removes two #4823

Closed
Zhirnoff opened this issue Jun 10, 2024 · 2 comments · Fixed by #4825 or #4827
Closed

In sequence mode, each press adds two characters and when deleted, also removes two #4823

Zhirnoff opened this issue Jun 10, 2024 · 2 comments · Fixed by #4825 or #4827
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.22.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode -> Sequence mode
  2. Start new sequence and press any letter
  3. Press Backspace to delete letter.

Actual behavior
In sequence mode, each press adds two characters and when deleted, also removes two

Expected behavior
In sequence mode, each press adds one character and when deleted, also removes one

Screenshots

2024-06-10_17h29_45.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]
@Zhirnoff Zhirnoff added bug Priority: High Macromolecules Sequence mode Bucket: Sequence mode related issues labels Jun 10, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.22.0-rc.4 milestone Jun 10, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 10, 2024
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4823 - In sequence mode, each press adds two characters and when del…
6fb4539 
…eted, also removes two

- added removing keydown subscription after editor destroy
@rrodionov91 rrodionov91 linked a pull request Jun 10, 2024 that will close this issue
#4823 - In sequence mode, each press adds two characters and when deleted, also removes two #4825
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4823 - In sequence mode, each press adds two characters and when del…
5a0fd66 
…eted, also removes two (#4825)

- added removing keydown subscription after editor destroy
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4823 - In sequence mode, each press adds two characters and when del…
67ab5a2 
…eted, also removes two

- added removing keydown subscription after editor destroy
@rrodionov91 rrodionov91 linked a pull request Jun 10, 2024 that will close this issue
#4823 - In sequence mode, each press adds two characters and when deleted, also removes two #4827
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 10, 2024
@rrodionov91
#4823 - In sequence mode, each press adds two characters and when del…
14d1b4f 
…eted, also removes two (#4827)

- added removing keydown subscription after editor destroy
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.4 Build at 2024-06-10; 17:29:31
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

@Zhirnoff
Copy link
Collaborator Author

2024-06-11_09h38_59.mp4

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.4]
Indigo version
[Version 1.21.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.22.0-rc.4
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff