Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow moving "small" structures in macro mode #4531

Closed
rrodionov91 opened this issue Apr 24, 2024 · 2 comments · Fixed by #4580
Closed

Allow moving "small" structures in macro mode #4531

rrodionov91 opened this issue Apr 24, 2024 · 2 comments · Fixed by #4580
Assignees
@ilya-asiyuk-epam
Labels
feature request Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.22.0-rc.2

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Apr 24, 2024 •
edited
Loading

Background
Functionality for movement of "small" molecules in macromolecules mode was disabled during the previous phase of implementation of macromolecules mode. Currently it is possible to move molecules however it does not affect molecule coordinates and after switching back to molecules mode the structure appears to the initial position defined in molecules mode last time.

Screen.Recording.2024-04-24.at.14.44.44.mov

Solution
It needs to apply changing of molecule structure coordinates during movement in macromolecules mode.
@rrodionov91 rrodionov91 added this to the Ketcher 2.22.0-rc.1 milestone Apr 24, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 30, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label May 6, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented May 6, 2024

Tests added to the automation table.

ilya-asiyuk-epam added a commit that referenced this issue May 7, 2024
@ilya-asiyuk-epam
#4531 - Allow moving and connecting "small" structures in macro mode
41609e3
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request May 7, 2024 that will close this issue
#4531 - Allow moving and connecting "small" structures in macro mode #4580
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue May 13, 2024
@ilya-asiyuk-epam
#4531 - Allow moving and connecting "small" structures in macro mode
9a06e76
ilya-asiyuk-epam added a commit that referenced this issue May 13, 2024
@ilya-asiyuk-epam
Merge pull request #4580 from epam/4531-allow-moving-and-connecting-s…
f63c4c9 
…mall-structures-in-macro-mode

#4531 - Allow moving and connecting "small" structures in macro mode
@AlexeyGirin AlexeyGirin mentioned this issue May 20, 2024
Open
@AlexeyGirin
Copy link
Collaborator

Verified.

Versions [e.g. v2.4.2].

  • Indigo Toolkit Version 1.21.0-dev.3.0-g6f55c664-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-20; 05:30:45
  • Chrome Version 124.0.6367.201 (Official Build) (64-bit)
  • Windows 10

This was referenced May 24, 2024
Closed
Open
Open
Open
@rrodionov91 rrodionov91 changed the title Allow moving and connecting "small" structures in macro mode Allow moving "small" structures in macro mode Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
feature request Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.22.0-rc.2
Development

Successfully merging a pull request may close this issue.

#4531 - Allow moving and connecting "small" structures in macro mode epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @ilya-asiyuk-epam