Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: In the Text-editing mode, when selecting nucleotides linked through phosphates R2-R2, an error appears in the Console #4508

Closed
ViktoriaTkacheva opened this issue Apr 21, 2024 · 2 comments · Fixed by #4538 or #4601
Closed

Macro: In the Text-editing mode, when selecting nucleotides linked through phosphates R2-R2, an error appears in the Console #4508

ViktoriaTkacheva opened this issue Apr 21, 2024 · 2 comments · Fixed by #4538 or #4601
Assignees
@DmitriiP-EPAM
Labels
bug Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.21.0-rc.3

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Steps to Reproduce

  1. Switch to the Macro mode
  2. Open this file (first unzip) Phosphates R2-R2.zip
  3. Switch to the Sequence mode - the Text-editing mode
  4. Select the structure

Actual behavior
The error appears in the Console DevTool (Uncaught RangeError: Maximum call stack size exceeded)
2024-04-21_21h12_02
rc.test.lifescience.opensource.epam.com-1713726743105.log

Expected behavior
There is no error in the Console DevTool

Screenshots

2024-04-19_11h50_28.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (124.0.6367.60) x64

Ketcher version 2.21.0-rc.1, Build at 2024-04-15; 20:06:01
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.21.0-rc.2 milestone Apr 21, 2024
@AlexeyGirin AlexeyGirin added the Sequence mode Bucket: Sequence mode related issues label Apr 25, 2024
DmitriiP-EPAM added a commit that referenced this issue Apr 25, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Specify the types
7296297
DmitriiP-EPAM added a commit that referenced this issue Apr 25, 2024
@DmitriiP-EPAM
#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna
a49fc40
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Apr 25, 2024 that will close this issue
#4508 – Macro: In the Text-editing mode, when selecting nucleotides linked through phosphates R2-R2, an error appears in the Console #4538
Merged
9 tasks
DmitriiP-EPAM added a commit that referenced this issue May 3, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Specify the types
2ca8aa5
DmitriiP-EPAM added a commit that referenced this issue May 3, 2024
@DmitriiP-EPAM
#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna
5f06a59
DmitriiP-EPAM added a commit that referenced this issue May 3, 2024
@DmitriiP-EPAM
Revert "#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna"
39145ee 
This reverts commit 5f06a59.
DmitriiP-EPAM added a commit that referenced this issue May 3, 2024
@DmitriiP-EPAM
#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna
87ab8dc
DmitriiP-EPAM added a commit that referenced this issue May 7, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Use an arrow function
ff82ff9
DmitriiP-EPAM added a commit that referenced this issue May 7, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Change the comments
23d5278
DmitriiP-EPAM added a commit that referenced this issue May 7, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Move the checking
8e59cb6
DmitriiP-EPAM added a commit that referenced this issue May 7, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Create isPartOfRNA
32bc955
NataliaLoginova pushed a commit that referenced this issue May 7, 2024
#4508 - Remove unnecessary method isPartOfRna
ee613b3
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Specify the types
7928eed
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna
d2e1a6a
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
Revert "#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna"
d6ee3c4 
This reverts commit 5f06a59.
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Bugfix (Phosphate.ts): Correct isPartOfRna
13d5da9
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Use an arrow function
4914a23
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Change the comments
75404a0
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Move the checking
b76cad9
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Create isPartOfRNA
c9bb91d
DmitriiP-EPAM pushed a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Remove unnecessary method isPartOfRna
49106c5
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Phosphate.ts): Delete the extra type cast
2ed2d2c
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Bugfix (DrawingEntity.ts): Delete the useless isPartOfRna. …
49e0430 
…We need it only for `Sugar` class
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 - Refactor (Sugar.ts): Rename isPartOfRNA
5c6f896
NataliaLoginova pushed a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4508 – Macro: In the Text-editing mode, when selecting nucleotides l…
eebf117 
…inked through phosphates R2-R2, an error appears in the Console (#4538)

* #4508 - Refactor (Phosphate.ts): Specify the types

* #4508 - Bugfix (Phosphate.ts): Correct `isPartOfRna`

* Revert "#4508 - Bugfix (Phosphate.ts): Correct `isPartOfRna`"

This reverts commit 5f06a59.

* #4508 - Bugfix (Phosphate.ts): Correct `isPartOfRna`

* #4508 - Refactor (Phosphate.ts): Use an arrow function

* #4508 - Refactor (Phosphate.ts): Change the comments

* #4508 - Refactor (Phosphate.ts): Move the checking

* #4508 - Refactor (Phosphate.ts): Create `isPartOfRNA`

* #4508 - Remove unnecessary method isPartOfRna

* #4508 - Refactor (Phosphate.ts): Delete the extra type cast

* #4508 - Bugfix (DrawingEntity.ts): Delete the useless `isPartOfRna`. We need it only for `Sugar` class

* #4508 - Refactor (Sugar.ts): Rename `isPartOfRNA`

---------

Co-authored-by: Natalia_Loginova1 <Natalia_Loginova1@epam.com>
DmitriiP-EPAM added a commit that referenced this issue May 9, 2024
@DmitriiP-EPAM
Backmerge: #4508 – Macro: In the Text-editing mode, when selecting nu…
9454a4c 
…cleotides linked through phosphates R2-R2, an error appears in the Console (#4538)

* #4508 - Bugfix (DrawingEntity.ts): Delete the useless `isPartOfRna`. We need it only for `Sugar` class

---------

Co-authored-by: Natalia_Loginova1 <Natalia_Loginova1@epam.com>
(cherry picked from commit eebf117)
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request May 9, 2024 that will close this issue
Backmerge: #4508 – Macro: In the Text-editing mode, when selecting nucleotides linked through phosphates R2-R2, an error appears in the Console #4601
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue May 9, 2024
@DmitriiP-EPAM
Backmerge: #4508 – Macro: In the Text-editing mode, when selecting nu…
47fd637 
…cleotides linked through phosphates R2-R2, an error appears in the Console (#4538) (#4601)

* #4508 - Bugfix (DrawingEntity.ts): Delete the useless `isPartOfRna`. We need it only for `Sugar` class

---------

Co-authored-by: Natalia_Loginova1 <Natalia_Loginova1@epam.com>
(cherry picked from commit eebf117)
@ViktoriaTkacheva
Copy link
Collaborator Author

Verified.

Indigo Toolkit Version 1.20.0-rc.2.0-g111a89f35-x86_64-linux-gnu-11.2.1
Ketcher Version 2.21.0-rc.2, Build at 2024-05-24; 09:07:47
Сhrome Version: (125.0.6422.61) x64
Windows 10 Pro (version 22H2) x64

image

@Zhirnoff
Copy link
Collaborator

2024-06-10_14h40_18

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.3]
Indigo version
[Version 1.20.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
bug Macromolecules Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.21.0-rc.3
5 participants
@AlexeyGirin @Zhirnoff @ViktoriaTkacheva @ilya-asiyuk-epam @DmitriiP-EPAM