Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure #3970

Closed
Zhirnoff opened this issue Jan 26, 2024 · 2 comments · Fixed by #4052 or #4063
Closed

Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure #3970

Zhirnoff opened this issue Jan 26, 2024 · 2 comments · Fixed by #4052 or #4063
Assignees
@ilya-asiyuk-epam
Labels
bug Firefox only
Milestone
Ketcher 2.18.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 26, 2024 •
edited
Loading

Steps to Reproduce

  1. Add any structure on canvas ( ring or chain)
  2. Select S-Group tool and add it to single atom ( Multiple group, SRU Polymer, Superatom ) or select any Functional Group or Salt and add to single atom and expand it

Actual behavior
Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure. The bug can only be reproduced in the Firefox browser.

Expected behavior
Brackets are displayed correctly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure. Brackets frame the atom (see screenshot)
2024-01-26_14h36_34

Screenshots

2024-01-26_14h37_00

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Firefox
  • Version 122.0 (64-bit)

Ketcher version
Version 2.18.0-rc.2
@Zhirnoff Zhirnoff added this to the Refined Backlog milestone Jan 26, 2024
ilya-asiyuk-epam added a commit that referenced this issue Feb 7, 2024
@ilya-asiyuk-epam
#3970 - Brackets are displayed incorrectly when a S-Group is added to…
fd09742 
… an atom or an expanded Functional Group or Salt is added to an atom of a structure
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Feb 7, 2024 that will close this issue
#3970 - Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure #4052
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Feb 8, 2024
@ilya-asiyuk-epam
#3970 - Brackets are displayed incorrectly when a S-Group is added to…
5b4ac3e 
… an atom or an expanded Functional Group or Salt is added to an atom of a structure
ilya-asiyuk-epam added a commit that referenced this issue Feb 8, 2024
@ilya-asiyuk-epam
#3970 - Brackets are displayed incorrectly when a S-Group is added to…
424adc4 
… an atom or an expanded Functional Group or Salt is added to an atom of a structure
ilya-asiyuk-epam added a commit that referenced this issue Feb 8, 2024
@ilya-asiyuk-epam
Merge pull request #4052 from epam/3970-brackets-are-displayed-incorr…
d21854f 
…ectly-when-a-s-group-is-added-to-an-atom-or-an-expanded-functional-group-or-salt-is-added-to-an-atom-of-a-structure

#3970 - Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure
ilya-asiyuk-epam added a commit that referenced this issue Feb 8, 2024
@ilya-asiyuk-epam
Backmerge: #3970 - Brackets are displayed incorrectly when a S-Group …
a06045d 
…is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Feb 8, 2024 that will close this issue
Backmerge: #3970 - Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure #4063
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Feb 9, 2024
@ilya-asiyuk-epam
Merge pull request #4063 from epam/3970-brackets-are-displayed-incorr…
ee7971d 
…ectly-when-a-s-group-is-added-to-an-atom-or-an-expanded-functional-group-or-salt-is-added-to-an-atom-of-a-structure

Backmerge: #3970 - Brackets are displayed incorrectly when a S-Group is added to an atom or an expanded Functional Group or Salt is added to an atom of a structure
@ilya-asiyuk-epam
Copy link
Collaborator

Merged into "master" and "release/2.18"

@Zhirnoff
Copy link
Collaborator Author

Tested. Bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Firefox only
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.18.0-rc.5
3 participants
@rrodionov91 @Zhirnoff @ilya-asiyuk-epam