Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aromatize/Dearomatize of having abbreviation (Salts and Solvents) on the canvas causes spontaneous random de-abbreviation #3891

Closed
AlexeyGirin opened this issue Jan 14, 2024 · 2 comments · Fixed by #4123 or #4135
Closed

Aromatize/Dearomatize of having abbreviation (Salts and Solvents) on the canvas causes spontaneous random de-abbreviation #3891

AlexeyGirin opened this issue Jan 14, 2024 · 2 comments · Fixed by #4123 or #4135
Assignees
@captain2b
Labels
bug Priority: High query features phase II
Milestone
Ketcher 2.19.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Open from file: Raskolbas.zip (unzip first)
  2. Press Aromatize button (Alt+A) or Dearomatize button (Ctrl+Alt+A)
  3. Select any Salts and Solvents from Structure Library
  4. Hover it over existed one
2024-01-15_01h27_40.mp4

Actual behavior
Abbreviations starts to lost collapsed state spontaneously

Expected behavior
Nothing happens

Issue found while testing epam/Indigo#1446

Desktop (please complete the following information):

  • OS: Win10
  • Browser Chrome Version 120.0.6099.130 (Official Build) (64-bit)

Ketcher version [e.g. v2.4.2].
Ketcher Version 2.18.0+dev.1 Build at 2024-01-11; 13:21:50
Indigo Toolkit Version 1.18.0-dev.4+1452.0-gaf1efce67-x86_64-linux-gnu-11.4.0
@AlexeyGirin AlexeyGirin added this to the Query Features - Phase II milestone Jan 14, 2024
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Jan 15, 2024 •
edited
Loading

This issue doesn't exist at RC
Ketcher Version 2.18.0-rc.1
Build at 2024-01-13; 09:02:02
Indigo Toolkit Version 1.18.0-rc.1.0-g4cbf4f3f5-x86_64-linux-gnu-11.2.1

This issue doesn't exist at PROD
Ketcher Version 2.15.0
Build at 2023-11-06; 15:42:20
Indigo Toolkit Version 1.14.0.0-gafaea530d-x86_64-linux-gnu-11.2.1

rrodionov91 added a commit that referenced this issue Feb 21, 2024
@rrodionov91
#3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solve…
89434c5 
…nts) on the canvas causes spontaneous random de-abbreviation

- fixed functional group id setting
@rrodionov91 rrodionov91 linked a pull request Feb 21, 2024 that will close this issue
#3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solvents) on the canvas causes spontaneous random de-abbreviation #4123
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solve…
5395b1d 
…nts) on the canvas causes spontaneous random de-abbreviation (#4123)

- removed resetting sgroup id in restruct
- added setting sgroup id on deserialisation step
- added functional groups id mapping to link functional groups properly during struct merge

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solve…
1682e2f 
…nts) on the canvas causes spontaneous random de-abbreviation

- fixed functional group id setting
@rrodionov91 rrodionov91 linked a pull request Feb 23, 2024 that will close this issue
Backmerge: #3891 - Aromatize/Dearomatize of having abbreviation (Salts and Solvents) on the canvas causes spontaneous random de-abbreviation #4135
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
Backmerge: #3891 - Aromatize/Dearomatize of having abbreviation (Salt…
b20d718 
…s and Solvents) on the canvas causes spontaneous random de-abbreviation (#4135)

- removed resetting sgroup id in restruct
- added setting sgroup id on deserialisation step
- added functional groups id mapping to link functional groups properly during struct merge

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Tested. Fixed.

2024-03-11_17h54_14.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@captain2b captain2b

Labels
bug Priority: High query features phase II
Projects
None yet
Milestone
Ketcher 2.19.0-rc.2
4 participants
@captain2b @rrodionov91 @AlexeyGirin @Zhirnoff