Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: System doesn't close Save dialog after Save button pressed #3820

Closed
AlexeyGirin opened this issue Dec 28, 2023 · 2 comments · Fixed by #3829
Closed

Macro: System doesn't close Save dialog after Save button pressed #3820

AlexeyGirin opened this issue Dec 28, 2023 · 2 comments · Fixed by #3829
Assignees
@Nitvex
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 28, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Put any monomer on the canvas
  3. Press Save as... button
    Save dialog appears - this is ok
  4. Press Save button
2023-12-28_14h30_46.mp4

Actual behavior
System saves canvas but Save dialog remain opened.

Expected behavior
System saves canvas and closes Save dialog.

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version
Version 2.17.0-rc.2
Build at 2023-12-27; 13:44:29

Indigo Toolkit
Version 1.17.0-rc.3.0-g1a7f60990-wasm32-wasm-clang-12.0.0
rrodionov91 added a commit that referenced this issue Jan 3, 2024
@rrodionov91
#3820 - Macro: System doesn't close Save dialog after Save button pre…
a8509e4 
…ssed

- added save modal closing after pressing save button
@rrodionov91 rrodionov91 linked a pull request Jan 3, 2024 that will close this issue
Macro: #3820 - System doesn't close Save dialog after Save button pressed #3829
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 3, 2024
@rrodionov91
#3820 - Macro: System doesn't close Save dialog after Save button pre…
9153412 
…ssed (#3829)

- added save modal closing after pressing save button

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 4, 2024

Test added to automation table

@AlexeyGirin
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
Development

Successfully merging a pull request may close this issue.

Macro: #3820 - System doesn't close Save dialog after Save button pressed epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff