Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: After removing the abbreviation in micro mode and switching to macro mode, the monomer disappears #3660

Closed
Zhirnoff opened this issue Dec 6, 2023 · 3 comments · Fixed by #3735
Closed

Macro: After removing the abbreviation in micro mode and switching to macro mode, the monomer disappears #3660

Zhirnoff opened this issue Dec 6, 2023 · 3 comments · Fixed by #3735
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2023

Steps to Reproduce

  1. Open Ketcher and switch to Macro mode
  2. Add monomers to canvas ( not connected by bonds )
  3. Switch to Micro mode
  4. Remove abbreviations from monomers
  5. Switch back to Macro mode

Actual behavior
After removing the abbreviation in micro mode and switching to macro mode, the monomer disappears

Expected behavior
After removing the abbreviation in micro mode and switching to macro mode, the monomer persists on canvas.

Screenshots

2023-12-06_12h48_39.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.1
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 4 milestone Dec 6, 2023
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Dec 8, 2023

Autotests added.

rrodionov91 added a commit that referenced this issue Dec 19, 2023
@rrodionov91
#3660 - Macro: After removing the abbreviation in micro mode and swit…
4d11af1 
…ching to macro mode, the monomer disappears

- restricted several operations with macro entities in micro mode (expand/remove abbreviation, replace, etc)
@rrodionov91 rrodionov91 linked a pull request Dec 19, 2023 that will close this issue
#3660 - Macro: After removing the abbreviation in micro mode and switching to macro mode, the monomer disappears #3735
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 21, 2023
@rrodionov91
#3660 - Macro: After removing the abbreviation in micro mode and swit…
9e5ad98 
…ching to macro mode, the monomer disappears (#3735)

* #3660 - Macro: After removing the abbreviation in micro mode and switching to macro mode, the monomer disappears

- restricted several operations with macro entities in micro mode (expand/remove abbreviation, replace, etc)

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jan 8, 2024

It is restricted to remove the abbreviation from monomers in micro mode.

@Zhirnoff
Copy link
Collaborator Author

Tested. Restricted to remove the abbreviation from monomers in micro mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff