Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut [Shift+Tab] for switching selection mode #3221

Closed
Nitvex opened this issue Aug 30, 2023 · 2 comments · Fixed by #3287
Closed

Add shortcut [Shift+Tab] for switching selection mode #3221

Nitvex opened this issue Aug 30, 2023 · 2 comments · Fixed by #3287
Assignees
@StarlaStarla
Labels
feature request Priority: High
Milestone
Ketcher 2.16.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Aug 30, 2023 •
edited by StarlaStarla
Loading

Background
Esc behaviour was changed in scope of #2127

Solution

  1. Esc should still reset current tool to Select tool

  2. Add shortcut [Shift+Tab] for switching modes of selection tool (lasso, rectangle, structure selection)

Alternatives
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@Nitvex Nitvex added this to the Ketcher 2.16.0-rc.1 milestone Aug 30, 2023
@Nitvex Nitvex self-assigned this Aug 30, 2023
@StarlaStarla StarlaStarla assigned StarlaStarla and unassigned Nitvex Sep 7, 2023
@StarlaStarla StarlaStarla changed the title [DRAFT] Add shortcut for switching selection mode Add shortcut [Shift+Tab]for switching selection mode Sep 8, 2023
@StarlaStarla StarlaStarla changed the title Add shortcut [Shift+Tab]for switching selection mode Add shortcut [Shift+Tab] for switching selection mode Sep 8, 2023
StarlaStarla added a commit that referenced this issue Sep 12, 2023
@StarlaStarla
#3221 Add shortcut [Shift+Tab] for switching selection mode
831309f
StarlaStarla added a commit that referenced this issue Sep 12, 2023
@StarlaStarla
#3221 change the shortcut for chlorine from "Shift+C" to just "l"
5f3f076
@StarlaStarla StarlaStarla linked a pull request Sep 12, 2023 that will close this issue
#3221 - add shortcut shift+tab for switching selection mode #3287
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Sep 15, 2023
@StarlaStarla
#3221 fix autotests
be0f277
StarlaStarla added a commit that referenced this issue Sep 15, 2023
@StarlaStarla
#3221 fix autotests
374cd3a
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 enhancement
a8f026a
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 enhancement
d20c334
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 fix autotest
32dddfc
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 fix autotest
a26a44e
@MartaWilliams
Copy link
Collaborator

Test case written

StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 remove duplicate page.goto('')
1d33985
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 enhancement
188035c
StarlaStarla added a commit that referenced this issue Sep 18, 2023
@StarlaStarla
#3221 add await to expect toBeVisible
cddbf70
Nitvex pushed a commit that referenced this issue Sep 19, 2023
@StarlaStarla
#3221 - add shortcut shift+tab for switching selection mode (#3287)
b4efc67 
* #3221 Add shortcut [Shift+Tab] for switching selection mode

* #3221 change the shortcut for chlorine from "Shift+C" to just "l"

* #3221 fix autotests

* #3221 enhancement

* #3221 fix autotest

* #3221 remove duplicate page.goto('')

* #3221 enhancement

* #3221 add await to expect toBeVisible
@ViktoriaTkacheva
Copy link
Collaborator

Preview. No comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
feature request Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.1
Development

Successfully merging a pull request may close this issue.

#3221 - add shortcut shift+tab for switching selection mode epam/ketcher
4 participants
@StarlaStarla @Nitvex @MartaWilliams @ViktoriaTkacheva