Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WASM loading performance #2654

Closed
Nitvex opened this issue May 23, 2023 · 2 comments · Fixed by #4893
Closed

Improve WASM loading performance #2654

Nitvex opened this issue May 23, 2023 · 2 comments · Fixed by #4893
Assignees
@rrodionov91 @AlexeyGirin
Labels
feature request Priority: High Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.23.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented May 23, 2023 •
edited by rrodionov91
Loading

Background
At the moment, WASM is embed as base64 string into JS-file. This needs to be changed to speed up WASM load.

Solution
Extract .wasm part from JS to separate file. This would reduce the file size and allow browser to cache WASM and speed up future loads.
Related Indigo issue: epam/Indigo#877
#185972429

Need to check integration with backend after indigo ticket will be completed.
@Nitvex Nitvex added this to the Refined Backlog milestone May 23, 2023
@Nitvex Nitvex self-assigned this May 23, 2023
@Zhirnoff Zhirnoff mentioned this issue Mar 13, 2024
Closed
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned Nitvex Apr 23, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 7, 2024
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that particular issue

rrodionov91 added a commit that referenced this issue Jun 25, 2024
@rrodionov91
#2654 - Improve WASM loading performance
a0067ae 
- added two ketcher-standalone builds: with base64 indigo wasm and with separate wasm file
rrodionov91 added a commit that referenced this issue Jun 25, 2024
@rrodionov91
#2654 - Improve WASM loading performance
5fc154a 
- added two ketcher-standalone builds: with base64 indigo wasm and with separate wasm file
@rrodionov91 rrodionov91 linked a pull request Jun 26, 2024 that will close this issue
#2654 - Improve WASM loading performance #4893
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 26, 2024
@rrodionov91
#2654 - Improve WASM loading performance (#4893)
ea4a36b 
- added two ketcher-standalone builds: with base64 indigo wasm and with separate wasm file
- updated indigo to 2.22.0-rc.2
@AlexeyGirin AlexeyGirin self-assigned this Jul 4, 2024
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 5, 2024 •
edited
Loading

Verified.
Full loading has become 13% faster (1 second better) on my machine
Minimal necessary loading time - 57% faster (3.5 seconds better) on my machine
image

Ketcher Version 2.22.0-rc.2 Build at 2024-06-26; 13:36:01
Indigo Version 1.22.0-dev.2.0-gd11d8c526-wasm32-wasm-clang-19.0.0
Win 10
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

@rrodionov91 rrodionov91 mentioned this issue Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

@AlexeyGirin AlexeyGirin

Labels
feature request Priority: High Test Cases Written Test cases has been written for that issue
Projects
Ketcher
Status: Ready for testing
Milestone
Ketcher 2.23.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2654 - Improve WASM loading performance epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff