Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracket is missing when opening a file RXN v2000/v3000 files with 'S-Group Properties Type = Multiple group' #2389

Closed
Zhirnoff opened this issue Mar 17, 2023 · 4 comments · Fixed by #3074
Closed

Bracket is missing when opening a file RXN v2000/v3000 files with 'S-Group Properties Type = Multiple group' #2389

Zhirnoff opened this issue Mar 17, 2023 · 4 comments · Fixed by #3074
Assignees
@vitaepam
Labels
bug regression Issue was found during regression
Milestone
Ketcher 2.15.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

Scenario1

  1. Launch Ketcher
  2. Open RXN v2000 file with 'S-Group Properties Type = Multiple group Multi.zip

Actual behavior
Pop-up message:
WARNING!
Unsupported S-group type found. Would you like to import structure without it? And file opens without one of S-Group bracket.
2023-03-17_16h20_26
2023-03-17_16h09_46

Expected behavior
File opens without pop-up message. With all added S-Group Properties and brackets on its places
2023-03-17_16h08_28

Scenario2

  1. Launch Ketcher
  2. Open RXN v3000 file with 'S-Group Properties Type = Multiple group rxnV3000Multiple.zip

Actual and Expected results same as for RXN v2000

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.3

Test case
[EPMLSOPKET-1903]
@Zhirnoff Zhirnoff added the bug label Mar 17, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.10.0-rc.1 milestone Mar 17, 2023
@Zhirnoff Zhirnoff added the regression Issue was found during regression label Mar 21, 2023
@Zhirnoff Zhirnoff changed the title Interaction with RXN v2000/v3000 files with 'S-Group Properties Type = Multiple group' Bracket is missing when opening a file RXN v2000/v3000 files with 'S-Group Properties Type = Multiple group' Mar 21, 2023
@KonstantinEpam23
Copy link
Collaborator

Check all supported sgroup types work correctly when opening from file.

@Zhirnoff Zhirnoff mentioned this issue Jun 13, 2023
Closed
@Nitvex Nitvex assigned vitaepam and unassigned Nitvex Jul 20, 2023
vitaepam added a commit that referenced this issue Aug 9, 2023
@vitaepam
#2389 – fix brackets rendering for s-groups
078b165
vitaepam added a commit that referenced this issue Aug 9, 2023
@vitaepam
#2389 - fix brackets display for S-Groups
cf2b176
vitaepam added a commit that referenced this issue Aug 9, 2023
@vitaepam
#2389 - fix TS issues and add e2e test
7a46395
vitaepam added a commit that referenced this issue Aug 9, 2023
@vitaepam
#2389 - add file to ignore TS any error
9c999c7
vitaepam added a commit that referenced this issue Aug 9, 2023
@vitaepam
#2389 - add file to ignore TS any error
a313fd0
@vitaepam vitaepam mentioned this issue Aug 9, 2023
Merged
8 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Aug 9, 2023

Test cases already written. Its regression bug.

vitaepam added a commit that referenced this issue Aug 11, 2023
@vitaepam
#2389 - remove brackets for DAT S-Groups
51a7077
vitaepam added a commit that referenced this issue Aug 11, 2023
@vitaepam
#2389 - fix autotests
4a13f2d
vitaepam added a commit that referenced this issue Aug 12, 2023
@vitaepam
#2389 - fix autotests
c687569
vitaepam added a commit that referenced this issue Aug 14, 2023
@vitaepam
#2389 - After review fixes
aea883b
vitaepam added a commit that referenced this issue Aug 15, 2023
@vitaepam
#2389 - remove waitForLoad
0a63a8b
vitaepam added a commit that referenced this issue Aug 15, 2023
@vitaepam
#2389 - update snapshots
b616392
vitaepam added a commit that referenced this issue Aug 18, 2023
@vitaepam
#2389 - added fixme() for erase-tool
e3f8596
vitaepam added a commit that referenced this issue Aug 24, 2023
@vitaepam
#2389 - add console for restruct
da7fdd5
vitaepam added a commit that referenced this issue Aug 24, 2023
@vitaepam
#2389 - Add GEN S-group as supported for rendering
0367610
vitaepam added a commit that referenced this issue Aug 24, 2023
@vitaepam
#2389 - Update auto-tests
4504481
@Zhirnoff
Copy link
Collaborator Author

Pre-tested.
2023-08-30_12h01_18

vitaepam added a commit that referenced this issue Aug 30, 2023
@vitaepam
Merge pull request #3074 from epam/2389-bracket-is-missing-for-some-s…
2b0a398 
…groups

#2389 - Bracket is missing when opening a file RXN v2000/v3000 files with 'S-Group Properties Type = Multiple group'
@vitaepam
Copy link
Collaborator

vitaepam commented Sep 4, 2023

Files now is opening, but looks like saving of such files does not work, @Zhirnoff do we need to create a new bug maybe?
Screenshot 2023-09-04 at 10 36 19

@vitaepam vitaepam mentioned this issue Sep 4, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaepam vitaepam

Labels
bug regression Issue was found during regression
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.15.0-rc.1
4 participants
@Nitvex @Zhirnoff @KonstantinEpam23 @vitaepam