Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Try fix wrong success oidc auth #516

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

callmevladik
Copy link
Contributor

Pull Request Template

Description

Tryfix scenario when user logins via oidc with wrong credentials and gets moved to edp pages when in fact he shouldn't be able to use app.

Fixes #515

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

Screenshots (if appropriate):

Additional context

Add any other context or screenshots about the feature request here.

@callmevladik callmevladik added the bug Something isn't working label Dec 11, 2024
@callmevladik callmevladik self-assigned this Dec 11, 2024
@callmevladik callmevladik requested a review from a team as a code owner December 11, 2024 11:38
@MykolaMarusenko
Copy link
Contributor

/recheck

@MykolaMarusenko MykolaMarusenko merged commit 4e2141d into master Dec 11, 2024
6 of 7 checks passed
@MykolaMarusenko MykolaMarusenko deleted the fix/try-fix-fail-oidc branch December 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Fix oidc wrong success scenario
2 participants