Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hardcoded Pipeline Timeout in createBuildPipelineRunInstance Function #390

Closed
moonmanua opened this issue Sep 23, 2024 · 1 comment

Comments

@moonmanua
Copy link

Description

Problem Summary:
The function createBuildPipelineRunInstance in the file src/k8s/groups/Tekton/PipelineRun/utils/createBuildPipelineRunInstance/index.ts contains a hardcoded value for the pipeline timeout at line 91. This should be replaced with a dynamic value that can be set based on the requirements.

Steps to Reproduce:

  1. Open the file src/k8s/groups/Tekton/PipelineRun/utils/createBuildPipelineRunInstance/index.ts.
  2. Navigate to line 91.
  3. Observe the hardcoded timeout value.

Expected Behavior:
The pipeline timeout should be dynamically set based on the requirements, rather than being hardcoded.

Actual Behavior:
The pipeline timeout is hardcoded as '1h0m0s'.

Screenshots / Code Snippet:

base.spec.timeouts = {
    pipeline: '1h0m0s',
};

Environment

  • OS: macOS Sonoma (aarch64)
  • IDE: IntelliJ IDEA 2024.2.2, Ultimate Edition
  • JDK/SDK Version: Java SDK version 19, Go SDK 1.22.5, Go programming language version 1.22

Additional Information

To implement this change, the function should allow setting the pipeline timeout dynamically based on input parameters or configuration, ensuring flexibility and adaptability for different pipeline requirements.

@SergK
Copy link
Member

SergK commented Oct 3, 2024

Fixed in #400 through #401
Will be available as part of the platform 3.10.0 release

@SergK SergK closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants