[feature:lib] Add support for paging #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @eonu did you have the opportunity to take a look at the two open PRs? |
|
Hi @xuanxu, sorry, I don't know why I didn't see them! Paging in particular is a really huge feature that I missed, so I'll try get around to it ASAP! Thank you so much for implementing both PRs. |
This was referenced Apr 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec specin the root directory).Reason
The arXiv API allows paging via the query interface and currently Arx is not making use of it. Paging results is needed to fully support the arXiv API.
Description
This PR adds support for the
startandmax_resultsparameters to control paging and get chucks of the results set at a time. By default they take the same default values specified in the API. Previously every request had a hardcoded max_results value of 10000 so this change should also speed up every Arx call.Specs and docs added.