Contains

[SeeThruHead]

I kinda was expecting this to not pass

  const wrapper2 = shallow(<Button><span>Hello</span><div>Goodbye</div></Button>);
  const expectedChildren = [
    <span>wrong</span>,
    <div>Goodbye</div>
  ];

  t.ok(wrapper2.contains(expectedChildren), 'should render children');

Any thoughts?

[lelandrichardson]

whoa. I'd call that a bug.

[SeeThruHead]

workarounds:

  // fails like expected
  const expectedChildren = [
    <span>bye</span>,
    <div>Goodbye</div>
  ];

  t.deepEqual(wrapper2.props().children, expectedChildren, 'should render children');

  // Passing
  t.ok(wrapper2.contains(<span>Hello</span>), 'should render children');
  t.ok(wrapper2.contains(<div>Goodbye</div>), 'should render children');

Maybe it's fine that contains only accepts single nodes?

[lelandrichardson]

@SeeThruHead Yeah. I'm not sure what contains would actually do when passed an array... I don't think the case is ever handled specifically so I'm not sure what it actually does in that case.

[SeeThruHead]

Looks like it will try to compare the array to every node using nodeEqual from './Utils'

I'll take a look at it later to see if I can figure out why nodeEqual(Array, Node) is passing.

[lelandrichardson]

@SeeThruHead I believe I've fixed this ^^. Thanks for reporting the bug!

[SeeThruHead]

Awesome thanks a lot @lelandrichardson