Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used ciphers may not always be reflected in stats output #156

Closed
oschaaf opened this issue Oct 3, 2019 · 1 comment
Closed

Used ciphers may not always be reflected in stats output #156

oschaaf opened this issue Oct 3, 2019 · 1 comment

Comments

@oschaaf
Copy link
Member

oschaaf commented Oct 3, 2019

Envoy stopped tracking usage count of all ciphers individually, and as of today now only a select few are tracked. This broke a test in NH and we opted to change to a supported cipher. However, it would be great to have this functionality back again for observation (and possibly automatic verification of) ciphers used.
A first attempt to restore this was proposed over at the Envoy repo [2], but was backed out / closed because of better ways to pull it of where suggested (see PR comments over at [2]).
[1] https://github.com/envoyproxy/nighthawk/pull/149/files/ef212fea98e9d6cce6894dca6a1d7366730adf7e#diff-06285750a6347275084b85de2bbc1311
[2] envoyproxy/envoy#8435

@oschaaf
Copy link
Member Author

oschaaf commented Jan 29, 2021

Closing this, as this was resolved via envoyproxy/envoy#14534

@oschaaf oschaaf closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant