api: adds request/response attributes ExtProc options #4496
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Oct 22, 2024
Comment on lines
+296
to
+297
| RequestAttributes: []string{"request.path"}, | ||
| ResponseAttributes: []string{"response.code"}, |
There was a problem hiding this comment.
not sure if this is the enough testing 😉
|
sorry I won't need one after I had an offline chat |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 203 203
Lines 31154 31166 +12
=======================================
+ Hits 20547 20557 +10
- Misses 9420 9421 +1
- Partials 1187 1188 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds obvious config options for the extproc:
requestAttributesandresponseAttributes.What this PR does / why we need it:
While I am developing a custom WAF external processing, I want to be able to
access attributes information while processing the requests listed below:
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/attributes#arch-overview-attributes
Which issue(s) this PR fixes:
ref: #3170