From acaf2b64335f9e327805f25d35ebeff13fe9e568 Mon Sep 17 00:00:00 2001 From: Lisa Lu Date: Tue, 3 Sep 2019 16:35:43 -0700 Subject: [PATCH 1/2] Add line on installing XCode Signed-off-by: Lisa Lu --- ci/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ci/README.md b/ci/README.md index 04864d581498..857e5f9595ab 100644 --- a/ci/README.md +++ b/ci/README.md @@ -133,7 +133,8 @@ The macOS CI build is part of the [CircleCI](https://circleci.com/gh/envoyproxy/ Dependencies are installed by the `ci/mac_ci_setup.sh` script, via [Homebrew](https://brew.sh), which is pre-installed on the CircleCI macOS image. The dependencies are cached are re-installed on every build. The `ci/mac_ci_steps.sh` script executes the specific commands that -build and test Envoy. +build and test Envoy. If Envoy cannot be built (`error: /Library/Developer/CommandLineTools/usr/bin/libtool: no output file specified (specify with -o output) +`), ensure that XCode is installed. # Coverity Scan Build Flow From 0a6aec7b8d5018d877d2b175c2f40c1f361006be Mon Sep 17 00:00:00 2001 From: Lisa Lu Date: Wed, 4 Sep 2019 14:30:57 -0700 Subject: [PATCH 2/2] Try again with sign-off Signed-off-by: Lisa Lu --- bazel/README.md | 1 + ci/README.md | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/bazel/README.md b/bazel/README.md index b99b9e50621e..499dd46b80cf 100644 --- a/bazel/README.md +++ b/bazel/README.md @@ -65,6 +65,7 @@ for how to update or override dependencies. ``` _notes_: `coreutils` is used for `realpath`, `gmd5sum` and `gsha256sum` + XCode is also required to build Envoy on macOS. Envoy compiles and passes tests with the version of clang installed by XCode 9.3.0: Apple LLVM version 9.1.0 (clang-902.0.30). diff --git a/ci/README.md b/ci/README.md index 857e5f9595ab..72d1600fac52 100644 --- a/ci/README.md +++ b/ci/README.md @@ -133,8 +133,8 @@ The macOS CI build is part of the [CircleCI](https://circleci.com/gh/envoyproxy/ Dependencies are installed by the `ci/mac_ci_setup.sh` script, via [Homebrew](https://brew.sh), which is pre-installed on the CircleCI macOS image. The dependencies are cached are re-installed on every build. The `ci/mac_ci_steps.sh` script executes the specific commands that -build and test Envoy. If Envoy cannot be built (`error: /Library/Developer/CommandLineTools/usr/bin/libtool: no output file specified (specify with -o output) -`), ensure that XCode is installed. +build and test Envoy. If Envoy cannot be built (`error: /Library/Developer/CommandLineTools/usr/bin/libtool: no output file specified (specify with -o output)`), +ensure that XCode is installed. # Coverity Scan Build Flow