Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump abseil-cpp commit #4034

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

clnperez
Copy link
Contributor

@clnperez clnperez commented Aug 2, 2018

To pick up a fix for compiling on ppc64le (Power)

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

Description: bump abseil-cpp commit. Without this fix, two projects' (gperftools and abseil-cpp) Power-specific function names conflict with each other.
Risk Level: Low
Testing: manual
Docs Changes: N/A
Release Notes: N/A

mattklein123
mattklein123 previously approved these changes Aug 2, 2018
@clnperez
Copy link
Contributor Author

clnperez commented Aug 2, 2018

@mattklein123 do those failures look related? What's the best way to test locally if so? I followed the dev instructions and ran, in a container off of my branch:
IMAGE_NAME="envoyproxy/envoy-build-${DISTRO}" IMAGE_ID=39de7eee23810914a03c9b158b8bd7b3814ac6f1 ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev'
Executed 270 out of 288 tests: 270 tests pass and 18 were skipped.

@mattklein123
Copy link
Member

@clnperez please merge master and it will fix itself.

To pick up a fix for compiling on ppc64le (Power)

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@mattklein123 mattklein123 merged commit 55606ec into envoyproxy:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants