Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//test/integration/... requires compiling all extensions #6736

Closed
mattklein123 opened this issue Apr 28, 2019 · 2 comments · Fixed by #11737
Closed

//test/integration/... requires compiling all extensions #6736

mattklein123 opened this issue Apr 28, 2019 · 2 comments · Fixed by #11737
Assignees
Labels
Milestone

Comments

@mattklein123
Copy link
Member

I have noticed that when testing //test/integration/... it compiles all extensions. I think this is probably because there is some server test in there that also compiles all extensions, but I'm not sure.

Optimally, we should be able to run these tests without having to compile any extra extensions beyond potentially core ones like router, HCM, etc. This is useful on platforms that won't support all extensions.

cc @junr03

@mattklein123 mattklein123 added this to the 1.11.0 milestone Apr 28, 2019
@mattklein123 mattklein123 modified the milestones: 1.11.0, 1.12.0 Jul 3, 2019
@mattklein123 mattklein123 modified the milestones: 1.12.0, 1.13.0 Oct 10, 2019
@mattklein123 mattklein123 modified the milestones: 1.13.0, 1.14.0 Dec 5, 2019
@mattklein123 mattklein123 modified the milestones: 1.14.0, 1.15.0 Mar 10, 2020
@mattklein123 mattklein123 self-assigned this May 5, 2020
@yanavlasov yanavlasov self-assigned this May 5, 2020
@yanavlasov
Copy link
Contributor

The only test that needs to compile all extensions is //test/integration:run_envoy_test. This test seems to test that envoy process fails with bogus command line parameters. This should work with envoy without any extensions at all, I think. Unless I'm missing something the solution is to create another target that builds the server without any extensions.

$ bazel query "rdeps(//test/integration/..., //source/exe:envoy-static)"
//test/integration:run_envoy_test
//source/exe:envoy-static
Loading: 0 packages loaded
$

@mattklein123
Copy link
Member Author

@yanavlasov I think there are a couple of others like the hot restart test that use the full binary. But yeah, the solution is to build the binary twice, one the real version and one the light version. Note that @jmarantz already has a custom binary going for the hot restart test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants