Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build a dynamic_opentracing plugin for Envoy #4963

Closed
Oberon00 opened this issue Nov 5, 2018 · 4 comments
Closed

How to build a dynamic_opentracing plugin for Envoy #4963

Oberon00 opened this issue Nov 5, 2018 · 4 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@Oberon00
Copy link
Contributor

Oberon00 commented Nov 5, 2018

Description:
In issue #4140 it is mentioned that a "A specific build process is required for the dynamic loading [of opentracing plugins] to work.". Is there any documentation of this build process? Are independent vendors even supposed to provide binary opentracing plugins for envoy? Background: I want to build such a plugin, and am thinking about what the best way to package or deploy it would be.

Relevant Links:
PR #2252
Issue #4140

@mattklein123 mattklein123 added the question Questions that are neither investigations, bugs, nor enhancements label Nov 5, 2018
@mattklein123
Copy link
Member

@rnburn would be great to get some docs on this or if there are docs better links?

@rnburn
Copy link
Contributor

rnburn commented Nov 5, 2018

Envoy statically links in the standard C++ library by default. The specific build process is referring to the additional steps that need to be taken to work with a statically linked standard library. (See this SO post for background).

Basically what you need to do is to use a version script when linking to keep symbols from being exported. You can look at Jaeger's build-plugin.sh script to see an example of how to set it up.

@stale
Copy link

stale bot commented Dec 5, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 5, 2018
@stale
Copy link

stale bot commented Dec 12, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants