Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Route Entry Metadata in External Authorization Filter #25134

Closed
RiverPhillips opened this issue Jan 24, 2023 · 4 comments
Closed

Support Route Entry Metadata in External Authorization Filter #25134

RiverPhillips opened this issue Jan 24, 2023 · 4 comments
Labels
area/ext_authz enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@RiverPhillips
Copy link
Contributor

Title: Support Route Entry Metadata in External Authorization Filter

Description:
External Authorization currently supports passing Dynamic Metadata. I would like to be able to pass metadata statically per route. This enhancement was made to the Rate Limiting filter in #13269 and I foresee the changes required by the External Authorization filter to be broadly similar.

After the changes it should be possible to configure it as follows:

metadata:
  filter_metadata:
    envoy.filters.external_authorization:
      foo: bar

This should result in foo being set on the filterMetadata map passed to ext_authz Check method

@RiverPhillips RiverPhillips added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jan 24, 2023
@RiverPhillips
Copy link
Contributor Author

RiverPhillips commented Jan 24, 2023

I would like to pick this up assuming it is an appropriate extension

@RyanTheOptimist RyanTheOptimist added area/ext_authz and removed triage Issue requires triage labels Jan 27, 2023
@RyanTheOptimist
Copy link
Contributor

cc: @esmet

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ext_authz enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants