Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.treat_upstream_connect_timeout_as_connect_failure deprecation #18445

Closed
alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18452
Closed

envoy.reloadable_features.treat_upstream_connect_timeout_as_connect_failure deprecation #18445

alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18452
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #14685 (http: reinstating prior connect timeout behavior) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 5, 2021
@alyssawilk alyssawilk self-assigned this Oct 5, 2021
@alyssawilk alyssawilk mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: removing treat_upstream_connect_timeout_as_connect_failure alyssawilk/envoy
1 participant
@alyssawilk