Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel internal env variable $TEST_TEMPDIR is used in build_setup.sh #16788

Closed
boringuy opened this issue Jun 2, 2021 · 5 comments · Fixed by #26778
Closed

Bazel internal env variable $TEST_TEMPDIR is used in build_setup.sh #16788

boringuy opened this issue Jun 2, 2021 · 5 comments · Fixed by #26778
Labels
area/build question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@boringuy
Copy link
Contributor

boringuy commented Jun 2, 2021

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged appropriately.

Title: Bazel internal env $TEST_TMPDIR variable is used in build_setup.sh

Description:
According to the link below, $TEST_TMPDIR is for bazel internal use only. "--test_tmpdir" should be use instead. Using $TEST_TMPDIR somehow has a side effect of setting bazel max_idle_secs to 15 instead of the default 3 hours which caused it to wipe the sandbox (I was using --sandbox-debug) every time I run do_ci.sh and wiping the sandbox takes a long time. Switching to use "--test_tmpdir" doesn't override the max_idle_secs. So, is this intentional so do_ci.sh will shutdown bazel basically immediately? If not, I can submit a PR to change build_setup.sh to use "--test_tmpdir" instead.

[optional Relevant Links:]
bazelbuild/bazel#11062

@boringuy boringuy added the triage Issue requires triage label Jun 2, 2021
@junr03
Copy link
Member

junr03 commented Jun 3, 2021

cc @lizan

@junr03 junr03 added area/build question Questions that are neither investigations, bugs, nor enhancements and removed triage Issue requires triage labels Jun 3, 2021
@boringuy
Copy link
Contributor Author

boringuy commented Jun 3, 2021

So, was trying out the change and turns out $TEST_TMPDIR also change the output base path, so if we don't set it, we also need to add bazel startup option --output_base or --output_user_root to mimic the current behavior. Since I am not familiar with existing ci environment, I am probably not the best to make a PR for this. So, this is more just a question and I can work around this locally.

@lizan
Copy link
Member

lizan commented Jun 21, 2021

Yes it is set intentionally for CI purpose. But we're open to change it to more explicit way by specifing --test_tmpdir and --output_base. In CI environment the idle secs should be small as well.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 21, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants