Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting dynamic metadata from external ratelimit service #14507

Closed
esmet opened this issue Dec 22, 2020 · 1 comment · Fixed by #14508
Closed

Support setting dynamic metadata from external ratelimit service #14507

esmet opened this issue Dec 22, 2020 · 1 comment · Fixed by #14508
Assignees
@esmet
Labels
area/ratelimit

Comments

@esmet
Copy link
Contributor

esmet commented Dec 22, 2020

It is possible to set dynamic metadata from external authorization service responses, but not from the ratelimit service. Let's make it possible in the ratelimit service. This will allow users to log that metadata in the access log, or pass the metadata along to other filters to do interesting things.
@esmet esmet added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 22, 2020
@esmet
Copy link
Contributor Author

esmet commented Dec 22, 2020

/assign

@esmet esmet mentioned this issue Dec 22, 2020
Merged
@mattklein123 mattklein123 added area/ratelimit and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esmet esmet

Labels
area/ratelimit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ratelimit: add dynamic metadata to ratelimit response esmet/envoy
2 participants
@esmet @mattklein123