How about add HeaderMatch for http local ratelimit?

[ydh926]

Title: HeaderMatch for http local ratelimit

Description:

For example, limit a special user's request, we may need HeaderMatch in limit config , like this:

              stat_prefix: http_local_rate_limiter
              token_bucket:
                max_tokens: 1
                tokens_per_fill: 1
                fill_interval: 600s
              filter_enabled:
                runtime_key: local_rate_limit_enabled
                default_value:
                  numerator: 100
                  denominator: HUNDRED
              filter_enforced:
                runtime_key: local_rate_limit_enforced
                default_value:
                  numerator: 100
                  denominator: HUNDRED
              match:
                  name: x-user
                  exact_match: Bill
                  invert_match: false

[wbpcode]

I think it's valuable. Sometimes we do need to do some extra match to decide if we need to make a flow control.
If the community approves, perhaps I can complete it.

[mattklein123]

The goal here should be to use the new generic matching support that @snowp is working on. I think we are making good progress on that.

[wbpcode]

@mattklein123 I've been looking forward to generic matching support for a long time, where can I get the latest progress?

[mattklein123]

@snowp should be able to summarize and/or point you to current status. I think we are pretty close to having something we can start to build on in different filters.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[hania-elayoubi]

@mattklein123 with #14462 now merged, how much closer are we to be able to accomplish the request in this issue?

Could you please point to reference syntax on how to do this in the yaml config, if it is different than the one ydh926 listed?

[snowp]

With what's merged today you should be able to trigger a skip filter action based on matching on the request headers, similar to how this test works:

envoy/test/integration/integration_test.cc

Lines 371 to 393 in e53227e

	name: matcher
	typed_config:
	"@type": type.googleapis.com/envoy.extensions.common.matching.v3.ExtensionWithMatcher
	extension_config:
	name: set-response-code
	typed_config:
	"@type": type.googleapis.com/test.integration.filters.SetResponseCodeFilterConfig
	code: 403
	matcher:
	matcher_tree:
	input:
	name: request-headers
	typed_config:
	"@type": type.googleapis.com/envoy.type.matcher.v3.HttpRequestHeaderMatchInput
	header_name: match-header
	exact_match_map:
	map:
	match:
	action:
	name: skip
	typed_config:
	"@type": type.googleapis.com/envoy.extensions.filters.common.matcher.action.v3.SkipFilter
	)EOF");

Happy to answer any questions you might have

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.