Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy Windows server code samples #13281

Closed
davinci26 opened this issue Sep 25, 2020 · 9 comments · Fixed by #16339
Closed

Envoy Windows server code samples #13281

davinci26 opened this issue Sep 25, 2020 · 9 comments · Fixed by #16339

Comments

@davinci26
Copy link
Member

davinci26 commented Sep 25, 2020

Description:

I would like to start working on examples (sandboxes) that run on Windows Server Container instead of Alpine Linux. I already got one working but I would like to get more samples to give a good onboarding experience for Windows users.

I have the following questions:

  1. Where should the examples be placed. Should we have a separate folder for Windows samples or share between the folders?
  2. Do we want to start testing the examples on Windows? @sunjayBhatia

The main issue that I encounter is that by definition the container setup is platform specific and it is hard to write platform agnostic code. One approach is to use powershell core for the samples which is open source and cross platform but I am not sure how familiar the community is.

Currently I have put the code on a personal repository to share it with you but I think the envoy project is better home for this code.

Let me know what you think!

@davinci26 davinci26 added the triage Issue requires triage label Sep 25, 2020
@davinci26
Copy link
Member Author

@envoyproxy/windows-dev

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Sep 25, 2020

Maybe we can use a single dockerfile with 2 different build stages? just be sure to only build the Linux stage on Linux and vice versa for Windows:

And/or just 2 different Docker compose files?

@davinci26
Copy link
Member Author

just be sure to only build the Linux stage on Linux and vice versa for Windows:

I think it is possible that someone might want to run the Linux samples on Windows. I think that should be possible although I haven't tried it out.

@phlax
Copy link
Member

phlax commented Sep 26, 2020

I already got one working but I would like to get more

could you post a WIP PR with the working example?

if we can review/update that one it could be a model for the rest

I think it is possible that someone might want to run the Linux samples on Windows.

iiuc - yep - i think its likely

@sunjayBhatia
Copy link
Member

I think it is possible that someone might want to run the Linux samples on Windows. I think that should be possible although I haven't tried it out.

Yeah, I bet we will have to have 2 separate docker compose files

@mattklein123 mattklein123 added area/windows and removed triage Issue requires triage labels Sep 28, 2020
@davinci26
Copy link
Member Author

could you post a WIP PR with the working example?

I will get one rolling and we can iterate more there.

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@sunjayBhatia sunjayBhatia added help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Dec 9, 2020
@sunjayBhatia
Copy link
Member

Maybe we can use a single dockerfile with 2 different build stages?

This doesn't work, docker build/compose is pretty dumb and tries to build all the stages even when you ask to run a specific one

@sunjayBhatia
Copy link
Member

Trying this out again the more problematic issue is that many examples use images that are linux specific and we may have to build our own for Windows (mostly just echo servers and we could use node.js etc. - though there isn't a Windows docker image available from upstream, some 3rd party images are)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants