-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msvc-cl test failures of test/extensions/quic_listeners/quiche #13273
Comments
Attn @ggreenway and @danzh2010 |
cc @envoyproxy/windows-dev |
Should be solved by #13787 |
Can you explain about the cause? Is it because Windows socket is level triggered? |
@danzh2010 basically yeah, the socket events don't always get fired when running tests in non-blocking mode with the code as-is, we had to use We had to either do something like this: #13918 or emulate edge triggering as in #13787 |
Can we close now that #13787 is in? From a code inspection it looks like the tests are not marked as Or repurpose as |
Appears #13787 has resolved, closing. |
Title: msvc-cl test failures of test/extensions/quic_listeners/quiche
Description:
The following two test failures occur on windows with the introduction of #12898 to wire in the quiche component.
Repro steps:
Build CI pipeline after dropping "fails_on_windows" from test/extensions/quic_listeners/quiche/integration/BUILD
Admin and Stats Output:
Config:
Logs:
Call Stack:
The text was updated successfully, but these errors were encountered: