Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race between active healthchecks and secrets delivery #12505

Closed
dastbe opened this issue Aug 5, 2020 · 2 comments
Closed

Race between active healthchecks and secrets delivery #12505

dastbe opened this issue Aug 5, 2020 · 2 comments

Comments

@dastbe
Copy link
Contributor

dastbe commented Aug 5, 2020

WIP: getting some reference configuration and logs to better illustrate the problem

We've been testing Envoy initialization times and we noticed that under certain scenarios Envoy takes much longer (60+s) to initialize. We were able to root cause this down to what we believe is a race condition between when TLS is configured on a cluster (ex. validation context) and when active healthcheck begins.

Specifically, we observe that the SDS request for tls context secret is sent roughly in parallel for when the active healthcheck begins. Because of this, the initial healthcheck will fail and the healthcheck interval will fall back to the no_traffic_interval. While for STATIC_DNS and EDS this appears to not delay Envoy initialization, it appears that Envoy using LOGICAL_DNS will wait out the no_traffic_interval to healthcheck again before it considers itself fully initialized.

@mattklein123
Copy link
Member

I think this is a dup of #12389?

@dio dio added the duplicate label Aug 7, 2020
@dastbe
Copy link
Contributor Author

dastbe commented Aug 19, 2020

Ah, yeah! I have another issue related to this (STATIC_DNS healthchecking) but will cut a new issue for that. Closing.

@dastbe dastbe closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants