Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add dynamic metadata to rate limit actions #11593

Closed
clarakosi opened this issue Jun 15, 2020 · 4 comments · Fixed by #11723
Closed

Proposal: Add dynamic metadata to rate limit actions #11593

clarakosi opened this issue Jun 15, 2020 · 4 comments · Fixed by #11723
Assignees
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@clarakosi
Copy link
Contributor

Description: Currently to pass information from the dynamic metadata to the rate limit actions one would need to use the Lua filter to append a header with the relevant information. Instead, it would be more useful to be able to use the dynamic metadata directly as one of the actions of the rate limiter.

The action can follow the current MetaData schema[1] to get the value:

actions:
  - { dynamic_metadata: { key: “…”, path: [] } }

key: The key name of metadata to retrieve the Struct from the metadata.
path: The path to retrieve the value from the Struct

Links:

  1. https://www.envoyproxy.io/docs/envoy/latest/api-v3/type/metadata/v3/metadata.proto.html
@htuch
Copy link
Member

htuch commented Jun 15, 2020

Seems reasonable functionality; how will a value in the action be interpreted?

@htuch htuch added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Jun 15, 2020
@clarakosi
Copy link
Contributor Author

I think we can interpret it the same way we interpret the values from the other actions.

@htuch
Copy link
Member

htuch commented Jun 16, 2020

SGTM, should I assign this to you?

@clarakosi
Copy link
Contributor Author

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants