Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environpatch.sh does not reflect current version of Environ for v1.1 #1

Closed
jhskone opened this issue Jul 9, 2019 · 1 comment
Closed

environpatch.sh does not reflect current version of Environ for v1.1 #1

jhskone opened this issue Jul 9, 2019 · 1 comment

Comments

@jhskone
Copy link

jhskone commented Jul 9, 2019 •
edited
Loading

Super benign, but will point out as message reflected when patching caused some initial confusion. v1.1 still sets ENVIRON_VERSION="1.0" in environpatch.sh

git describe --tags
v1.1
grep ENVIRON_VERSION Environ/patches/environpatch.sh
export ENVIRON_VERSION="1.0"
@edan-bainglass
Copy link
Contributor

Apologies for the 2+ year delay. This matter has been addressed. Thanks

@jerrypgreenberg jerrypgreenberg mentioned this issue Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhskone @edan-bainglass