Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract conversion between Scalar and Uint to the scheme parameters level #63

Closed
fjarri opened this issue Nov 18, 2023 · 0 comments · Fixed by #99
Closed

Extract conversion between Scalar and Uint to the scheme parameters level #63

fjarri opened this issue Nov 18, 2023 · 0 comments · Fixed by #99
Labels
code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 18, 2023

See mul_by_point(), mul_by_generator(), uint_from_scalar(). This connection should really be established on SchemeParameters level, because implementors of that trait are the ones fixing the scalar and integer types in a single parameters object. Especially this needs to be done in connection with #27.

Also here it may be worth it to split to_scalar() (returning an error if the range is exceeded) and to_scalar_reduced() (that will reduce the integer to the scalar range).

@fjarri fjarri added the code quality Making things simpler label Nov 18, 2023
@fjarri fjarri added this to the v0.2.0 milestone Nov 26, 2023
@fjarri fjarri mentioned this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Making things simpler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant