Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opcache status monitor #944

Merged

Conversation

freephile
Copy link
Contributor

Added opcache.php (and data-sample.php) from https://github.com/rlerdorf/opcache-status.git into the ServerPerformance files. (htdocs role)

However, I changed the opcache.php script to use our already-in-use jquery and d3 in the ServerPerformance directory. Rasmus' version pulls files from cloudflare which is not ideal. In a quick test of functionality, it seems to be happy with js library versions.

<script src="//cdnjs.cloudflare.com/ajax/libs/d3/3.0.1/d3.v3.min.js"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>

changed to
./js/d3.js (v 3.5.14)
./js/jquery-3.1.0.min.js

data-sample.php just provides a mock implementation of the opcache functions in case opcache is disabled - so you get a chart instead of an error. There are no external resources.

##Testing
See https://demo.qualitybox.us/ServerPerformance/opcache.php for an example.

##ToDo
add some sort of restriction on who can access /ServerPerformance

@jamesmontalvo3 jamesmontalvo3 changed the base branch from master to opcache September 15, 2018 02:40
@jamesmontalvo3
Copy link
Contributor

@freephile merging this into the opcache branch I merged #943 into.

@jamesmontalvo3 jamesmontalvo3 merged commit ad95249 into enterprisemediawiki:opcache Sep 15, 2018
@jamesmontalvo3 jamesmontalvo3 mentioned this pull request Sep 17, 2018
2 tasks
@freephile freephile deleted the featureMonitorOpcache branch July 10, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants