Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support IPNS in contenthashes + show the stored content string even if wrong #358

Closed
lyricalpolymath opened this issue Jun 11, 2019 · 6 comments

Comments

@lyricalpolymath
Copy link
Contributor

we know that this domain is using an IPNS hash (not IPFS)
https://manager.ens.domains/name/www.wealdtech.eth (on mainnet)

can we support it and make it show?
cc @makoto

In any case, if the content inserted is wrong we should still show what it is, and show the warning sign that it is malformed. right now it can't be "debugged" by a user of the manager

Screenshot 2019-06-11 at 10 39 20

@makoto
Copy link
Member

makoto commented Jun 11, 2019

That's pending on Jim's PR on multicodec to be merged multiformats/multicodec#136 . Once done, then we need to ask https://github.com/pldespaigne/content-hash to support IPNS

@lidel
Copy link

lidel commented Jun 24, 2019

Note that /ipns/ paths are mutable, which means content behind such address can change without the need for updating anything in ENS.

Are you sure you want to allow that type of pointer in ENS?
My impression was that ENS contracts are deterministic and always point at immutable content, but maybe it is not a requirement?

Are there any docs about this policy?

@etam
Copy link

etam commented Feb 6, 2020

@lidel
Ens supports also bzz, onion and onion3 addresses. Bzz can be a Feed, which is mutable, just like IPNS. Onion addresses can return dynamic content, like any http server.

@etam
Copy link

etam commented Feb 6, 2020

@makoto pldespaigne/content-hash#30 is done.

(disclaimer: I'm not involved in any development. I just registered my ENS domain and was surprised that I can't use IPNS hash)

@hacdias
Copy link

hacdias commented May 3, 2020

@makoto pinging just to ask if there are any plans to support this. This is a must-have feature and having a first-hand support on the ENS app would be awesome 😄

@NoahZinsmeister
Copy link

adding some additional context:

Uniswap recently migrated its interface entirely to IPFS (https://uniswap.org/blog/ipfs-uniswap-interface/). as part of this transition, the contenthash of uniswap.eth was set to /ipns/app.uniswap.org. however, this had to be done manually because it's not supported in the ens app, and it also doesn't display correctly in the ens app. would love to see native IPNS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants