Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] キーボードの可変幅対応 #398

Closed
wants to merge 4 commits into from
Closed

[Refactoring] キーボードの可変幅対応 #398

wants to merge 4 commits into from

Conversation

ensan-hcl
Copy link
Owner

@ensan-hcl ensan-hcl commented Feb 14, 2024 •
edited
Loading

  • 現在の実装はscreenWidthを固定と想定しているため、動的な変更ができない
  • iPadOSのSplit Viewなどで問題になっていた
  • screenWidthをvariableStateに移動することでこの問題を解決する
  • また、GeometryReaderとPreferenceで幅の取得を行うことで、回転やUpsideComponentの追加の実装が簡素になった
  • 着せ替えのシェアのスクショが壊れている問題を修正する
  • 初回起動時の描画がうまくいかない問題を修正する
  • 着せ替えの一覧画面の更新

@ensan-hcl ensan-hcl linked an issue Feb 14, 2024 that may be closed by this pull request
[Refactoring Plan] 画面サイズ周りの複雑な実装を修正する #396
Open
@ensan-hcl ensan-hcl closed this Apr 27, 2024
@ensan-hcl
Copy link
Owner Author

しばらく動かしてないので一旦閉じた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactoring Plan] 画面サイズ周りの複雑な実装を修正する
1 participant
@ensan-hcl