refactor(daemon): Synchronize host makeBundle()
#2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizes the host's `makeBundle()` following the pattern established by `makeUnconfined()`. Eliminates the host's `provideWorkerFormulaIdentifier()`, which is everywhere replaced with the synchronous `prepareWorkerFormulaIdentifier()`.
12 tasks
rekmarks
force-pushed
the
rekmarks-synchronize-makeBundle
branch
from
e90ab98 to
eb82858
Compare
kriskowal
approved these changes
Mar 9, 2024
| /** @type {import('./types.js').ReadableBlobFormula} */ | ||
| const formula = { | ||
| type: 'readable-blob', | ||
| content: contentSha512, |
There was a problem hiding this comment.
It would be nice if we could use the content address as the formula identifier. That could be handy for avoiding unnecessary transfers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses: #2086
Synchronizes the host's
makeBundle()following the pattern established bymakeUnconfined(). Eliminates the host'sprovideWorkerFormulaIdentifier(), which is everywhere replaced with the synchronousprepareWorkerFormulaIdentifier(). Performs some opportunistic refactors ofmakeXandincarnateXwhereX === 'Bundle' | 'Unconfined'.