Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to SES lockdown shim #1853

Closed
leotm opened this issue Nov 8, 2023 · 0 comments · Fixed by #1854
Closed

Add version number to SES lockdown shim #1853

leotm opened this issue Nov 8, 2023 · 0 comments · Fixed by #1854
Labels
enhancement New feature or request metamask

Comments

@leotm
Copy link
Contributor

leotm commented Nov 8, 2023

What is the Problem Being Solved?

After downloading a lockdown shim, it's hard to remember which version it is later

e.g. curl -O https://npmfs.com/download/ses/0.18.8/dist/ses.cjs
but it's difficult to tell the version purely from inspecting the file

Description of the Design

Start the bundled lockdown file with a comment containing the version number

Security Considerations

Scaling Considerations

Test Plan

npm run build
head dist/ses.cjs # ensure correct version present as comment on line 1
npm run test

Upgrade Considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metamask
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants