From f51c5d2036bd4ca6c9be9c1933da905ad7f47d0d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 16 Nov 2022 15:38:03 -0800 Subject: [PATCH 1/3] Clarify MIN_CHROME_VERSION applies to modern Edge [NFC] --- src/settings.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/settings.js b/src/settings.js index 647da3772e4cc..768af5168ab15 100644 --- a/src/settings.js +++ b/src/settings.js @@ -1785,6 +1785,9 @@ var MIN_EDGE_VERSION = 0x7FFFFFFF; // Specifies the oldest version of Chrome. E.g. pass -sMIN_CHROME_VERSION=58 to // drop support for Chrome 57 and older. // Chrome 75.0.3770 was released on 2019-06-04 +// This setting also applies to modern Chromium-based Edge, which shares version +// numbers with Chrome (see notes above on MIN_EDGE_VERSION), so for both of +// those browsers you only need to set MIN_CHROME_VERSION. // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported. // [link] var MIN_CHROME_VERSION = 75; From d7a2fd7933760272fce34b8c10332e39281f117d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Thu, 15 Feb 2024 16:46:14 -0800 Subject: [PATCH 2/3] Update src/settings.js --- src/settings.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/settings.js b/src/settings.js index c291b4668a976..0339d46974746 100644 --- a/src/settings.js +++ b/src/settings.js @@ -1842,8 +1842,7 @@ var MIN_SAFARI_VERSION = 140100; // Specifies the oldest version of Chrome. E.g. pass -sMIN_CHROME_VERSION=58 to // drop support for Chrome 57 and older. // This setting also applies to modern Chromium-based Edge, which shares version -// numbers with Chrome (see notes above on MIN_EDGE_VERSION), so for both of -// those browsers you only need to set MIN_CHROME_VERSION. +// numbers with Chrome. // Chrome 85 was released on 2020-08-25. // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported. // Minimum supported value is 32, which was released on 2014-01-04. From 2882560bd17235a08ca0e5c6587d42f1d332ad2d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Tue, 20 Feb 2024 15:13:19 -0800 Subject: [PATCH 3/3] update docs --- site/source/docs/tools_reference/settings_reference.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/site/source/docs/tools_reference/settings_reference.rst b/site/source/docs/tools_reference/settings_reference.rst index c524e4883f013..141e9c4695ce7 100644 --- a/site/source/docs/tools_reference/settings_reference.rst +++ b/site/source/docs/tools_reference/settings_reference.rst @@ -2441,6 +2441,8 @@ MIN_CHROME_VERSION Specifies the oldest version of Chrome. E.g. pass -sMIN_CHROME_VERSION=58 to drop support for Chrome 57 and older. +This setting also applies to modern Chromium-based Edge, which shares version +numbers with Chrome. Chrome 85 was released on 2020-08-25. MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported. Minimum supported value is 32, which was released on 2014-01-04.