Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some missing props in the is-prop-valid package #813

Closed
quantizor opened this issue Aug 21, 2018 · 0 comments · Fixed by #814
Closed

Some missing props in the is-prop-valid package #813

quantizor opened this issue Aug 21, 2018 · 0 comments · Fixed by #814

Comments

@quantizor
Copy link
Contributor

quantizor commented Aug 21, 2018 •
edited
Loading

@Andarist recommended we check out is-prop-valid styled-components/styled-components#1694 (comment) and it looks to be pretty solid. However, there are a couple missing props based on our existing tests:

  • "challenge" (attribute on the keygen element)
  • "x-" <- mozilla tags, similar to data- or aria-*
  • "valueLink" (react 15 era deprecated prop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated isPropValid props list emotion-js/emotion
1 participant
@quantizor