-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for "programmatic" usage #358
Comments
@sreenivasulureddysura can you clarify this? |
@sreenivasulureddysura, do you mean "programmatic" as in calling Granian from Python instead of cli? If so, that's true. This way of using Granian is not documented. One would have to check code to see how Lines 257 to 304 in 0a85e88
I could add this use-case to README.md. BTW, are there any plans to have a dedicated documentation website? |
Correct, I changed the title and the naming comes from Uvicorn (https://www.uvicorn.org/#running-programmatically).
IMHO at the moment there's still few content for launching a website; probably relying on markdown files within the GH repo is fine at the moment, in the same way we have those for other projects in the organization like renoir. |
@gi0baro Let's bring all the markdown files and deploy it using the github page. Mkdocs library will help in the deploy it. If you are okay with Mkdocs I will submit the PR with the basic structure. |
Again, there's no enough content/reasons to publish (yet?) a website about Granian. And if and when that become a need, it would probably be a subdomain of emmett.sh website or even if on its own domain, built in a similar way. None of the projects in Emmett organization use Mkdocs; I would avoid having a single project with a different toolset/workflow, and if there's any valid reason to change that organization-wide, we should have that discussion separately from this issue. Let's start by having documentation in place with just markdown files, then post-pone further considerations at the proper time. |
@gi0baro |
How about as a first (small) step we re-organize the current root md file into multiple ones and link from the root md file (in places where it might be necessary)? :) It's easier to read and it'll also be easier to transition once @gi0baro decides it's time to move the docs to a standalone domain. FWIW, I think the thoroughness and quality of information in the docs is much more important than them having their own domain. I'll start with making a PR for programmatic usage ☝🏽 |
Sounds good to me; the only warning point to take into account is that
I totally agree.
Thank you for the effort! |
Currently Granian documentation is not there. Example: document
The text was updated successfully, but these errors were encountered: