cppcheck: ignore redundantAssignment and selfAssignment for registers in llcan.h

rbiasini · rbiasini · commit f45dd04c6797 · 2019-07-08T17:16:15.000-07:00
diff --git a/board/drivers/llcan.h b/board/drivers/llcan.h
@@ -29,6 +29,7 @@ bool llcan_set_speed(CAN_TypeDef *CAN_obj, uint32_t speed, bool loopback, bool s
   }
 
   // reset
+  // cppcheck-suppress redundantAssignment ; it's a register
   CAN_obj->MCR = CAN_MCR_TTCM | CAN_MCR_ABOM;
 
   #define CAN_TIMEOUT 1000000
@@ -80,6 +81,7 @@ void llcan_init(CAN_TypeDef *CAN_obj) {
 void llcan_clear_send(CAN_TypeDef *CAN_obj) {
   CAN_obj->TSR |= CAN_TSR_ABRQ0;
   CAN_obj->MSR &= ~(CAN_MSR_ERRI);
+  // cppcheck-suppress selfAssignment ; needed to clear the register
   CAN_obj->MSR = CAN_obj->MSR;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ bool llcan_set_speed(CAN_TypeDef *CAN_obj, uint32_t speed, bool loopback, bool s`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`// reset`
	`32`	`+ // cppcheck-suppress redundantAssignment ; it's a register`
`32`	`33`	`CAN_obj->MCR = CAN_MCR_TTCM \| CAN_MCR_ABOM;`
`33`	`34`
`34`	`35`	`#define CAN_TIMEOUT 1000000`
`@@ -80,6 +81,7 @@ void llcan_init(CAN_TypeDef *CAN_obj) {`
`80`	`81`	`void llcan_clear_send(CAN_TypeDef *CAN_obj) {`
`81`	`82`	`CAN_obj->TSR \|= CAN_TSR_ABRQ0;`
`82`	`83`	`CAN_obj->MSR &= ~(CAN_MSR_ERRI);`
	`84`	`+ // cppcheck-suppress selfAssignment ; needed to clear the register`
`83`	`85`	`CAN_obj->MSR = CAN_obj->MSR;`
`84`	`86`	`}`
`85`	`87`