Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h1 heading is set to display:none #159

Closed
MHassanSaqib opened this issue Jul 14, 2021 · 4 comments · Fixed by #171
Closed

h1 heading is set to display:none #159

MHassanSaqib opened this issue Jul 14, 2021 · 4 comments · Fixed by #171

Comments

@MHassanSaqib
Copy link

I have noticed that the h1 heading is set to display: none, I couldn't notice any impact of this class on the tabs, is it redundant?. It is breaking the quilljs editor. Might also impact other functionality or packages.

.relationship-tabs-panel h1 {
    display: none;
}
@RVxLab
Copy link
Collaborator

RVxLab commented Jul 22, 2021

It's entirely possible that it's redundant, but I'm not able to say for sure.

If you can find evidence that this is a dedundant selector I'd gladly accept a PR for it.

@Adrion
Copy link

Adrion commented Oct 13, 2021

Trix and NovaTrumbowyg are impacted too.
Does it hide actual elements ? I can't manage too find any h1 which require this display:none property

@Broutard
Copy link

impact editorjs package too.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 13, 2022

This should be fixed in 1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants