-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why the blurry appearance? #334
Comments
There is no blur added to the toast, which browser are you using and which os? |
I created two reproductions so you can see the difference. this is a reproduction of the default, exactly as it appears on the website. just click the button, in the preview, to see the toast (like on the website): this is the same default code, just with one addition: the options that remove the filter (as I mentioned in the initial message): if you place both windows side by side and click on the buttons, you will see that the last example I gave (with the options that remove the filter) has a clear appearance. in the original example (without disabling the filter) it is blurred. if this is unintentional, it is important to find the source of the problem and fix it. if it's intentional, we should have a way to disable this behavior without having to style everything from scratch. I'm using Windows. the problem mainly exists on Chromium-based browsers (Chrome, Edge, Opera and others). On Firefox the problem exists, but it is subtle. |
I'm not able to reproduce on any of the sandboxes. Like I said, nothing in the code adds a blur. It's likely a browser bug related to Windows. Good temporary solution could be adding |
Is it fixed on this preview link? https://sonner-git-fix-blurry-appearance-emilkowalski-s-team.vercel.app/ |
I have also noticed this. But I have experienced that before when I used transform: translate (mostly when using percentage values). I imagine this has something to do with positioning the element in a not integer pixel values and the way the browser decides to do the rendering when that happens. But I haven't looked at any of the code so I can't be sure. In my experience this happens on Windows in most Chromium based browsers (it appears blurry like that in Vivaldi, Chrome, Opera but not on Firefox for example). |
In the current published version (1.4.0), I tested and confirmed the issue in the following environments: Windows 10 22H2 19045.4046:
Ubuntu 22.04.3:
as I said before, on Firefox the problem is very slight.
In the provided link, apparently it's fixed. |
Fixed in #336 |
Fixed indeedd @emilkowalski! Nice one. What was the fix? |
Describe the feature / bug 📝:
I took this screenshot from the package website. the appearance of toasts is blurred in all cases, and it is not possible to disable this behavior (at least not completely).
I use the following code to disable this effect:
however, this code only works for the first toast. the rest (old) remain blurred.
appearance like this, at least for me, is somewhat undesirable. There needs to be a way to disable this without having to style everything from scratch.
Steps to reproduce the bug 🔁:
the text above makes it clear. it is default behavior.
The text was updated successfully, but these errors were encountered: