Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would a GPU make this code run faster? #408

Closed
brandon-holt opened this issue Oct 16, 2024 · 3 comments
Closed

Would a GPU make this code run faster? #408

brandon-holt opened this issue Oct 16, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@brandon-holt
Copy link
Contributor

Would a GPU make this code run faster for making recommendations, training model, etc.?

@AdrianSosic
Copy link
Collaborator

Hi @brandon-holt, this is a duplicate of #356, hence closing the issue. As you can see there, the discussion has already started with a list of open TODOs. But yes, the code execution can largely benefit from GPU support!

@AdrianSosic AdrianSosic added the duplicate This issue or pull request already exists label Oct 16, 2024
@brandon-holt
Copy link
Contributor Author

@AdrianSosic Thank you!

So all I need to do is set torch.set_default_device("cuda") before i add_measurements() and recommend()?

And what version of baybe starts supporting GPU?

@AdrianSosic
Copy link
Collaborator

Hi @brandon-holt, I'm afraid you misunderstood me 😬 The support is not yet there. I actually don't expect that much needs to be adjusted to get it running (ideally, this should only require setting some device configuration in a few places) but it's also not a super high priority at the moment, I have to say. Perhaps @Hrovatin can look into this as her next work item? Can discuss this with the team early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants