Re-add local/dev volta for folks not using corepack #2128
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Sep 25, 2024
| }, | ||
| "volta": { | ||
| "node": "20.14.0", | ||
| "pnpm": "8.15.9" |
There was a problem hiding this comment.
matches packageManager
There was a problem hiding this comment.
tbh, volta should probably just read packageManager and .npmrc, and only optionally have the volta package.json thing.
and then also do away with the required extends config, and traverse to the top by default. :-\
NullVoxPopuli
commented
Sep 25, 2024
| @@ -68,5 +68,9 @@ | |||
| "unlabeled": ":question: Unlabeled" | |||
| }, | |||
| "wildcardLabel": "unlabeled" | |||
| }, | |||
| "volta": { | |||
| "node": "20.14.0", | |||
There was a problem hiding this comment.
matches .npmrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unless folks know of a way to only enable corepack for certain projects?
it's been problematic on my work repo, so I have it globally disabled.