Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsdom to fix punycode deprecation messages from tr46, psl, and whatwg-url #2127

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Sep 25, 2024

when using npx punycode-detector, folks will see these lines:

❯ npx punycode-detector
Scanning for punycode usages, this may take a moment.
There are 11 imports/requires of 'punycode' : The node builtin (which is deprecated) and not the 'punycode/' userland package.
Set(11) {
  ✂️ ... ✂️
  'node_modules/.pnpm/psl@1.9.0/node_modules/psl/index.js',
  'node_modules/.pnpm/psl@1.9.0/node_modules/psl/dist/psl.js',
  'node_modules/.pnpm/tr46@2.1.0/node_modules/tr46/index.js',
  'node_modules/.pnpm/whatwg-url@8.7.0/node_modules/whatwg-url/dist/url-state-machine.js',
  'node_modules/.pnpm/tr46@0.0.3/node_modules/tr46/index.js',
  'node_modules/.pnpm/whatwg-url@5.0.0/node_modules/whatwg-url/lib/url-state-machine.js'
}

To learn more about punycode, checkout their README:

	https://github.com/mathiasbynens/punycode.js

To resolve, folks can use overrides:

  "tr46@<5.0.0": "^5.0.0",
  "whatwg-url@<14.0.0": "^14.0.0",
  "psl": "github:lupomontero/psl#a789d0381c886da02eb8594da0761860657c08ba",

and things seem to work just fine.


And:

@embroider/test-setup 4.0.0
├─┬ @embroider/compat 3.6.1 peer
│ ├─┬ @embroider/core 3.4.15 peer
│ │ └─┬ jsdom 16.7.0
│ │   └─┬ tough-cookie 4.1.4
│ │     └── psl 1.9.0
│ └─┬ jsdom 16.7.0
│   └─┬ tough-cookie 4.1.4
│     └── psl 1.9.0
├─┬ @embroider/core 3.4.15 peer
│ └─┬ jsdom 16.7.0
│   └─┬ tough-cookie 4.1.4
│     └── psl 1.9.0

And

@embroider/test-setup 4.0.0
├─┬ @embroider/compat 3.6.1 peer
│ ├─┬ @embroider/core 3.4.15 peer
│ │ └─┬ jsdom 16.7.0
│ │   ├─┬ data-urls 2.0.0
│ │   │ └── whatwg-url 8.7.0
│ │   └── whatwg-url 8.7.0
│ └─┬ jsdom 16.7.0
│   ├─┬ data-urls 2.0.0
│   │ └── whatwg-url 8.7.0
│   └── whatwg-url 8.7.0
├─┬ @embroider/core 3.4.15 peer
│ └─┬ jsdom 16.7.0
│   ├─┬ data-urls 2.0.0
│   │ └── whatwg-url 8.7.0
│   └── whatwg-url 8.7.0
└─┬ @embroider/webpack 4.0.5 peer
  ├─┬ @embroider/babel-loader-9 3.1.1
  │ └─┬ @embroider/core 3.4.15 peer
  │   └─┬ jsdom 16.7.0
  │     ├─┬ data-urls 2.0.0
  │     │ └── whatwg-url 8.7.0
  │     └── whatwg-url 8.7.0
  ├─┬ @embroider/core 3.4.15 peer
  │ └─┬ jsdom 16.7.0
  │   ├─┬ data-urls 2.0.0
  │   │ └── whatwg-url 8.7.0
  │   └── whatwg-url 8.7.0
  ├─┬ @embroider/hbs-loader 3.0.3
  │ └─┬ @embroider/core 3.4.15 peer
  │   └─┬ jsdom 16.7.0
  │     ├─┬ data-urls 2.0.0
  │     │ └── whatwg-url 8.7.0
  │     └── whatwg-url 8.7.0
  └─┬ jsdom 16.7.0
    ├─┬ data-urls 2.0.0
    │ └── whatwg-url 8.7.0
    └── whatwg-url 8.7.0
ember-source-channel-url 3.0.0
└─┬ node-fetch 2.7.0
  └── whatwg-url 5.0.0
lint-to-the-future 2.0.0
└─┬ node-fetch 2.7.0
  └── whatwg-url 5.0.0

and tr46 is a dep of whatwg-url

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Sep 25, 2024
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review September 25, 2024 15:51
@NullVoxPopuli NullVoxPopuli changed the title Bump jsdom to fix punycode deprecation messages from tr46 and whatwg-url Bump jsdom to fix punycode deprecation messages from tr46, psl, and whatwg-url Sep 25, 2024
@ef4 ef4 merged commit e9b6d77 into stable Sep 26, 2024
215 checks passed
@ef4 ef4 deleted the bump-jsdom-to-fix-punycode branch September 26, 2024 01:09
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants