speedup windows ci on stable #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
speedup-windows-ci-on-stable
branch
from
3ead9cf
to
2036122
Compare
ef4
reviewed
Sep 23, 2024
| @@ -12,7 +12,7 @@ export function explicitRelative(fromDir: string, toFile: string) { | |||
| if (!isAbsolute(result) && !result.startsWith('.')) { | |||
| result = './' + result; | |||
| } | |||
| if (isAbsolute(toFile) && result.endsWith(toFile)) { | |||
| if (isAbsolute(toFile) && result.split(sep).join('/').endsWith(toFile)) { | |||
There was a problem hiding this comment.
I think if this is necessary the real bug is elsewhere. Callers are supposed to be passing toFile in system format. If they're passing it in unix format on windows, that is the bug.
There was a problem hiding this comment.
i copied this from main. #2048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.