add basic watch file support #2105
Conversation
| @@ -147,7 +147,7 @@ export function renderEntrypoint( | |||
|
|
|||
| return { | |||
| src: entryTemplate(params), | |||
| watches: [], | |||
| watches: ['app/**/*'], | |||
There was a problem hiding this comment.
I've tried this locally and it seems to be all we need to get it working 🤷
There was a problem hiding this comment.
This is another place where we need to be doing things as in d850898
There was a problem hiding this comment.
Instead of hard-coding the string "app".
| @@ -330,7 +330,7 @@ function shouldSplitRoute(routeName: string, splitAtRoutes: (RegExp | string)[] | |||
|
|
|||
| export function getAppFiles(appRoot: string): Set<string> { | |||
| const files: string[] = walkSync(appRoot, { | |||
| ignore: ['_babel_filter_.js', 'app.js', 'assets', 'testem.js', 'node_modules'], | |||
| directories: false, | |||
There was a problem hiding this comment.
I removed the ignore because we now target the app folder as our appRoot so we don't need these ignores, and I added directories false because we only care about files 😂
|
im trying this in my vite watch mode pr, because currently its not detecting any new files. This is also not working, i think its missing changes in vite/resolver.ts |
|
i think it should resolve to the full path to |
|
@mansona i think this could further be improved by limiting the updates to create/delete. Currently this solution would invalidate the file on every file change in app dir. But we only need to do it for create/delete. The file updates are handled by vite. |
I'm not saying that this PR fixes all of our needs for watching app files, but since we are targeting real files on disk now and not a rewritten app this seems like it goes a decent way towards fixing things 🤷 If we're going to encourage people to try this out this week then maybe we can merge this and work on tests for it in our next office hours?