This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Adds Module Unification & Octane Update blog post #3848
[WIP] Adds Module Unification & Octane Update blog post #3848
Changes from 2 commits
cfef799
f86af9d
33f860d
05c9873
3d9dc6f
d2a3bf3
aa737a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably just skip this, since scoped packages is a much bigger problem, and this draws some attention to "doesn't nested components above have the same issue?". (IMO, not really, but still.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: on top of that,
@
usually mean named arguments, overloading that sigil here is too uncanny.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually grammatically correct: it's past perfect tense, plus the past participle of have.
For example, this sentence in the present perfect:
Becomes this sentence in the past perfect: