rfc: ember-data | deprecate-non-strict-types #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
T-ember-data
hjdivad
approved these changes
Apr 26, 2021
Comment on lines
+16
to
+18
| Deprecates when the `type` for a record provided by a user differs from the resolved | ||
| type, thereby removing the need to configure `ember-inflector` to treat `types` as `uncountable` | ||
| in order to use plural model names, and removing the dasherization constraint. |
There was a problem hiding this comment.
I'd recommend clarifying what "resolved" means in this context.
There was a problem hiding this comment.
The resolved type means the on-disk file-path derived type. So for instance a model at app/models/foos/otherUsers.js has the resolved type foos/otherUsers while app/models/foos/bar-user.js has the resolved type foos/bar-user. For the latter example, foos/barUser and foos/barUsers could both currently be supplied to ember-data in most contexts today and still result in a successful lookup of the model. Said uses would be required to be refactored to use the resolved type.
I'll try to add a note to this effect to the RFC for clarification.
This was referenced May 21, 2021
Closed
25 tasks
6 tasks
runspired
added a commit
that referenced
this pull request
Sep 22, 2023
Advance RFC #740 `"EmberData | Deprecate Non Strict Types"` to Stage Ready for Release
3 tasks
runspired
added a commit
that referenced
this pull request
Sep 24, 2023
Advance RFC #740 `"EmberData | Deprecate Non Strict Types"` to Stage Released
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full Text: Rendered